Various CMake updates #1043
Merged
Various CMake updates #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Jan 16, 2025
KFilipek
requested changes
Jan 17, 2025
PatKamin
approved these changes
Jan 21, 2025
mostly adding new "section" comments and a misspell fix.
It should be either 'L0' or 'Level Zero'
Improper version set in CMake means, our lib will be wrongly configured and libumf.so.0.0.0 will be produced... which most likely is not expected (unless it's a developer's build).
for 'build_umf_test' and 'add_umf_ipc_test'. It's for proper parsing of CMake files.
Contributor
Author
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
added an yet another rule for 'add_umf_ipc_test' in .cmake-format
lukaszstolarczuk
force-pushed
the
cmake-updates
branch
from
79b5050 to
079ecef
Compare
Contributor
|
@KFilipek please resolve or update the discussion if still needed |
KFilipek
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each commit introduces a small fix/update around CMake. The "most important" part is to add a warning if a version is set to 0.0.0, which should be rather unexpected for users.
Checklist